Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

Fix the example that deals with item wrapping #28

Merged
merged 4 commits into from
Apr 5, 2017

Conversation

pmatsinopoulos
Copy link
Contributor

Corrected error that had to do with item wrapping.

Corrected error that had to do with item wrapping.
@pmatsinopoulos
Copy link
Contributor Author

@ljones140 Can you review this and merge please (It seems that I am not authorized to merge)

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 671438f on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

1 similar comment
@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 671438f on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

@ljones140
Copy link
Contributor

@pmatsinopoulos can you bump the version. This is a open source gem hosted on ruby gems so we need to be vigilant with versioning

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d5b4b6d on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5b4b6d on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5b4b6d on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5b4b6d on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5b4b6d on pmatsinopoulos:patch-1 into bca2357 on simplybusiness:master.

Copy link
Contributor

@ljones140 ljones140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will merge now

@ljones140 ljones140 merged commit f9a2473 into simplybusiness:master Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants