This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Sane logging by default #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 29, 2015 08:51
With more verbose logging, the rabbit_feed.log will begin to fill up disk quickly. This ensures that the rabbit_feed log will not consume more than 1GB of disk.
Logs to file if there is a log directory Auto rotates the log file
This cleans up the spec files a bit by removing some duduplicate code
Will log to `log/rabbit_feed.log` using json formatting unless otherwise specified.
|
|
||
| def default_logger | ||
| if File.directory? 'log' | ||
| Logger.new('log/rabbit_feed.log', 10, 100.megabytes) |
There was a problem hiding this comment.
I thought you don't use parentheses ;-)
There was a problem hiding this comment.
Good catch, think of the bytes wasted by the unnecessary punctuation!
|
Looks good to me, signed-off-by: @sparrovv |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at all of our apps, and there is a lot of duplication when it comes to setting up rabbit_feed logging - I've changed rabbit_feed to use reasonable defaults for its logging, including rotating the logfile every 100MB up to 1GB.
@sparrovv @dawid-sklodowski @calo81 Could you please sign off?
I also removed some duplication with spec_helper requires.