Fix for request being passed as sort_params parameter to Report __init__

simplyopen-it · Mar 27, 2018 · 73c097e · 73c097e
1 parent decc5e6
commit 73c097e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/admin_reports/views.py b/admin_reports/views.py
@@ -245,7 +245,8 @@ def _export(self, form=None):
         }
         return render(self.request, 'admin/export.html', ctx)
 
-    def post(self, *args, **kwargs):
+    def post(self, request, *args, **kwargs):
+        # TODO: FIXME: you shouldn't just pass request args to Report __init__() this is straight up dangerous.
         self.report = self.report_class(*args, **kwargs)
         if not self.report.has_permission(self.request):
             raise PermissionDenied()