Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic around major versions #379

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mglaman
Copy link
Collaborator

@mglaman mglaman commented Mar 7, 2024

No description provided.

Copy link
Collaborator Author

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic needs some extra eyes and sanity review

@mglaman
Copy link
Collaborator Author

mglaman commented Mar 7, 2024

This failed on 11.x-dev:

2024-03-07T04:16:33.272Z - 65e93f5c7dd073fbdae06ebb# /bin/sh -c cd "${DOCROOT}" && ../vendor/bin/drush si standard --db-url=mysql://tugboat:tugboat@mysql:3306/tugboat --account-name=admin --account-pass=admin -y
 You are about to:
 * Create a sites/default/settings.php file
 * DROP all tables in your 'tugboat' database.

 // Do you want to continue?: yes.                                              

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [notice] Performed install task: install_verify_requirements
 [error]  The submitted value mysql in the Database type element is not allowed. 
 [warning] Undefined array key "host" Connection.php:132
 [warning] Undefined array key "username" Connection.php:165
 [warning] Undefined array key "password" Connection.php:165

In install.core.inc line 964:

It didn't have a base preview, I'm guessing, so something was missing

@mglaman mglaman marked this pull request as draft March 7, 2024 04:22
@mglaman
Copy link
Collaborator Author

mglaman commented Mar 7, 2024

Lagoon environment used a "dev" tugboat, so that may be a problem also. Looking into it more tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant