-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Region Detection #35
Comments
The following prompt shall be shown to the user when the app is started if If "Don't show this again" is tapped on, the prompt is dismissed and does not appear again. Since we have over 70 regions now, finding the correct region in the dropdown menu can be exhausting. A switch in the Profile menu should switch between the dropdown and a button. By pressing the button, the 3 nearest regions are shown to the user and he can select one of them or cancel. For this purpose, a new API endpoint was created:
A succesful response is either a 200 with an empty body or a 200 with the folowing content:
... A line beginning with a ! is still to be ignored.
The three nearest regions are calculated by comparing the current GPS location to the GPS locations from the regions file described above. |
A 200 with an empty body means that the regions did not change. |
Done |
We need a small change to this. We do not want uploads with region UNKNOWN anymore. Therefore, the region prompt form above is changed to this: Furthermore, when the upload button is clicked and the region is UNKNOWN, this prompt will be shown to the user instead of triggering the upload. And show this prompt to every user once after the update. Even if the user has already set a region. |
Is it really the right direction where this is going? It should be easily possible to identify the region from the trip location data. There should be no user input necessary and it could be done in the backend (even retrospectively for already received data). The ongoing proposal uses current location, bothers the user (in some cases at app startup time, which is worst) and depends on app state ("Don't show again"). Apologies if this comes off as snarky, I don't mean it that way! I'm just curious: What are the points in favor of this design? |
We can determine the region of each ride using the GPS information contained in that ride. But it gets complicated when a ride goes through multiple regions. In that case, it is up to the user to choose his/her region. |
Closing issues as it is already in production |
No description provided.
The text was updated successfully, but these errors were encountered: