Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes test case failing because jpeg carving is not implemented #469

Merged
merged 17 commits into from
Apr 27, 2024

Conversation

simsong
Copy link
Owner

@simsong simsong commented Apr 26, 2024

Closes #468

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.53%. Comparing base (13d05cd) to head (c3d7bcc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   48.18%   48.53%   +0.36%     
==========================================
  Files         112      112              
  Lines       13249    13263      +14     
==========================================
+ Hits         6383     6437      +54     
+ Misses       6866     6826      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsong simsong marked this pull request as ready for review April 27, 2024 02:08
@simsong
Copy link
Owner Author

simsong commented Apr 27, 2024

That took far too long. Something changed on the GitHub MacOS VM and the homebrew libraries were no longer being found.

@simsong simsong merged commit 3b51a23 into main Apr 27, 2024
10 checks passed
@simsong simsong deleted the dev-hotfix-nist-cfreds branch April 27, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bulk_extractor ignoring jpeg_carve_mode; does not carve contiguous JPEGs
1 participant