Skip to content

Commit

Permalink
Update configure.ac (#236)
Browse files Browse the repository at this point in the history 
Per #232 (comment)
  • Loading branch information
@simsong
simsong committed Feb 25, 2021
1 parent 6205065 commit f909240
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure.ac
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ case $host in
;;

*)
CXXFLAGS="$CXXFLAGS -Wno-address-of-packed-member"
CXXFLAGS="$CXXFLAGS -Wno-address-of-packed-member -fno-new-ttp-matching"
;;
esac

Expand Down

6 comments on commit f909240

@catap
Copy link
Contributor

@catap catap commented on f909240 Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsong unfortunately it brokes build by clang on macOS like:

clang: error: unknown argument: '-fno-new-ttp-matching'

Anyway, without this options it is building on Apple Clang 14 like a charm :)

@simsong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsong unfortunately it brokes build by clang on macOS like:

clang: error: unknown argument: '-fno-new-ttp-matching'

Hi @catap . Can you please let me know which version of macOS you are using?

@catap
Copy link
Contributor

@catap catap commented on f909240 Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simsong macOS 12; but I may test it on any another version of macOS :)

@catap
Copy link
Contributor

@catap catap commented on f909240 Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the issue is simple: clang is default compiler for macOS and it simple doesn't support such option. By adding this you had turn tcpflow into gcc-only project :(

@catap
Copy link
Contributor

@catap catap commented on f909240 Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: https://clang.llvm.org/docs/ClangCommandLineReference.html for supported options by the last clang

@simsong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we have code for probing which options should be used. This option should be added there instead. Do you want to submit a correction?
The code is here:
https://github.com/simsong/tcpflow/blob/master/m4/slg_gcc_all_warnings.m4

Please sign in to comment.