Don’t silence optional target exceptions

lib/activity_notification/apis/notification_api.rb

@@ -542,7 +542,7 @@ def publish_to_optional_targets(options = {})
             [optional_target_name, true]
           rescue => e
             Rails.logger.error(e)
-            [optional_target_name, e]
+            raise e
           end
         else
           [optional_target_name, false]

spec/concerns/apis/notification_api_spec.rb

@@ -136,9 +136,17 @@
           Comment._optional_targets[:users] = @current_optional_target
         end
 
-        it "generates notifications even if some optional targets raise error" do
-          notifications = described_class.notify(:users, @comment_2)
-          expect(notifications.size).to eq(2)  
+        it "raises an capturable exception" do
+          expect { described_class.notify(:users, @comment_2) }.to raise_error(RuntimeError)
+        end
+
+        it "allows an exception to be captured to continue" do
+          begin
+            notifications = described_class.notify(:users, @comment_2)
+            expect(notifications.size).to eq(2)
+          rescue => e
+            next
+          end
         end
       end
     end