Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key uniqueness validation #119

Closed

Conversation

irondnb
Copy link

@irondnb irondnb commented Nov 29, 2019

  • validation for uniqueness of key-target in Subscription model

  • move create_subbscription method to build_subscription, so we can check for errors before save without rising exception

  • left create_subbscription method for test purposes

  • refactor some test: lazy loading objects

@coveralls
Copy link

coveralls commented Nov 29, 2019

Coverage Status

Coverage decreased (-0.01%) to 99.989% when pulling 7cce4cb on irondnb:add-key-uniqueness-validation into 9db86fe on simukappu:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.882% when pulling fad3bc6 on irondnb:add-key-uniqueness-validation into 9559d13 on simukappu:development.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.882% when pulling fad3bc6 on irondnb:add-key-uniqueness-validation into 9559d13 on simukappu:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.882% when pulling fad3bc6 on irondnb:add-key-uniqueness-validation into 9559d13 on simukappu:development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.882% when pulling fad3bc6 on irondnb:add-key-uniqueness-validation into 9559d13 on simukappu:development.

@irondnb
Copy link
Author

irondnb commented Nov 29, 2019

working on tests

Edit: Since db was cleared only once, there will be duplicates during test.
Temporarly i'm clearing it before each test which result in extended execution time.
Sadly, there are still some mysql test that failing

@simukappu simukappu force-pushed the development branch 2 times, most recently from b554b87 to 9f775c6 Compare November 30, 2019 10:42
@irondnb
Copy link
Author

irondnb commented Dec 10, 2019

@simukappu I've tried, but it end up in more commits 🤕
I will just create another PR with new branch.

Note: I've drop support for dynamodb for now and will fix it in another PR

@simukappu
Copy link
Owner

I've rewrite your contribution and pushed as this commit: 3b46954
Also added dynamoid uniqueness validation.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants