-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key uniqueness validation #119
Add key uniqueness validation #119
Conversation
Disable sprockets version to ~>3
3 similar comments
working on tests Edit: Since db was cleared only once, there will be duplicates during test. |
b554b87
to
9f775c6
Compare
9f775c6
to
b6cb17d
Compare
… in manifest file
@simukappu I've tried, but it end up in more commits 🤕 Note: I've drop support for dynamodb for now and will fix it in another PR |
352bde9
to
30545c4
Compare
2507df2
to
156040a
Compare
156040a
to
3b46954
Compare
I've rewrite your contribution and pushed as this commit: 3b46954 Thank you for your contribution! |
validation for uniqueness of key-target in Subscription model
move create_subbscription method to build_subscription, so we can check for errors before save without rising exception
left create_subbscription method for test purposes
refactor some test: lazy loading objects