Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant double splat #157

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Remove redundant double splat #157

merged 1 commit into from
Feb 12, 2021

Conversation

onk
Copy link
Contributor

@onk onk commented Feb 11, 2021

Just clean up the code.

ref:

@onk
Remove redundant double splat
1714011 
ref:

* Add `{ optional: true }` when Rails 5
  - 4459cab
* Add double splat
  - f989d75
* Drop Rails 4.2 Support
  - 181c259
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1714011 on onk:remove_double_splat into 1b4a90b on simukappu:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1714011 on onk:remove_double_splat into 1b4a90b on simukappu:master.

@simukappu
Copy link
Owner

LGTM. Will be merged. Thanks!

@simukappu simukappu merged commit e731219 into simukappu:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onk @coveralls @simukappu