Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom association name for subscriptions #162

Closed
wants to merge 1 commit into from

Conversation

apuntovanini
Copy link

Issue #161, if available:

Summary

Right now I just added a failing spec for custom association name. I assumed we can use the same config for custom subscriptions table, but of course I'll let you decide this @simukappu

There are many methods inside the subscriber.rb that depends on the default subscriptions association name. As said, if anyone attaches this concern to a model that has subscriptions associations, it breaks functionality

Please give me instructions on the direction you prefer to move forward about this
Thanks

@apuntovanini
Copy link
Author

I took a stronger path on this, since we need this functionality for production shortly. I created a fork in which I renamed associations and methods from :subscription(s) to :notification_subscription. I know it's a bit opinionated, but naming it :subscription is just about the same. If you think this will work for the gem, let me know, I'll wrap the PR against master branch
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant