fixed #notifiable_path #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#notifiable_path now calls super#notifiable_path if it exists
1 similar comment
|
Hi @upstill This bug fix is good, but I have a few comments for your pull request. Could you update this?
Thanks! |
simukappu
force-pushed
the
development
branch
from
bf6dad4
to
25d7720
Compare
simukappu
force-pushed
the
development
branch
from
22b02bc
to
f913732
Compare
simukappu
force-pushed
the
development
branch
3 times, most recently
from
7185859
to
6148657
Compare
simukappu
added a commit
that referenced
this pull request
Aug 25, 2018
|
I have added your request in adobe referenced commit and release them as v1.5.1. I will close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#notifiable_path would work if the notifiable class actually defined it. However, if it was defined in a superclass, the Notifiable module's override of the method would ignore it and throw an error. Now a superclass can define #notifiable_path and it will get called.