[Monk] Against All Odds is bugged with wrong effect subtype.

simulationcraft · Jun 25, 2024 · 76565ac · 76565ac
1 parent fb4d082
commit 76565ac
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/engine/class_modules/monk/sc_monk.cpp b/engine/class_modules/monk/sc_monk.cpp
@@ -7960,7 +7960,9 @@ void monk_t::create_buffs()
   buff.against_all_odds =
       make_buff_fallback( talent.shado_pan.against_all_odds->ok(), this, "against_all_odds", find_spell( 451061 ) )
           ->set_default_value_from_effect( 1 )
-          ->set_pct_buff_type( STAT_PCT_BUFF_AGILITY )
+          ->set_default_value_from_effect_type(
+              A_MOD_PERCENT_STAT )  // bugged should be A_MOD_TOTAL_STAT_PERCENTAGE (137)
+//          ->set_pct_buff_type( STAT_PCT_BUFF_AGILITY )
           ->add_invalidate( CACHE_AGILITY );
 
   buff.flurry_charge =
@@ -8602,6 +8604,20 @@ double monk_t::composite_attack_power_multiplier() const
   return ap;
 }
 
+// monk_t::composite_attribute() ==========================
+
+double monk_t::composite_attribute( attribute_e attr ) const
+{
+  auto a = player_t::composite_attribute( attr );
+
+  // TODO: remove if fixed
+  if ( attr == ATTR_AGILITY && buff.against_all_odds->check() )
+    a += base.stats.attribute[ attr ] * buff.against_all_odds->check_value();
+
+  return a;
+}
+
+
 // monk_t::composite_dodge ==============================================
 
 double monk_t::composite_dodge() const

diff --git a/engine/class_modules/monk/sc_monk.hpp b/engine/class_modules/monk/sc_monk.hpp
@@ -1471,6 +1471,7 @@ struct monk_t : public stagger_t<parse_player_effects_t, monk_t>
   action_t *create_action( util::string_view name, util::string_view options ) override;
   double composite_melee_auto_attack_speed() const override;
   double composite_attack_power_multiplier() const override;
+  double composite_attribute( attribute_e ) const;
   double composite_dodge() const override;
   double composite_mastery() const override;
   double non_stacking_movement_modifier() const override;