Skip to content

Commit

Permalink
fix: Hovering on a map shows a weird card title when it shouldn't
Browse files Browse the repository at this point in the history
  • Loading branch information
billyc committed Dec 17, 2021
1 parent fe4c8b4 commit d10c1ce
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions src/charts/area.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class VueComponent extends Vue {
@Prop({ required: true }) subfolder!: string
@Prop({ required: true }) files!: string[]
@Prop({ required: true }) config!: any
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
Expand All @@ -39,7 +39,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/bar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class VueComponent extends Vue {
@Prop() files!: string[]
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -46,7 +46,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/bubble.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default class VueComponent extends Vue {
@Prop({ required: true }) config!: any
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -38,7 +38,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/heatmap.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class VueComponent extends Vue {
@Prop() datamanager!: DashboardDataManager
@Prop({ required: false }) zoomed!: boolean
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -39,7 +39,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/line.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class VueComponent extends Vue {
@Prop({ required: true }) config!: any
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -37,7 +37,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/pie.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class VueComponent extends Vue {
@Prop({ required: true }) config!: any
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -38,7 +38,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
4 changes: 2 additions & 2 deletions src/charts/scatter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class VueComponent extends Vue {
@Prop({ required: true }) config!: any
@Prop() datamanager!: DashboardDataManager
@Prop() cardId!: string
@Prop({ required: true }) title!: string
@Prop({ required: true }) cardTitle!: string
private globalState = globalStore.state
Expand All @@ -37,7 +37,7 @@ export default class VueComponent extends Vue {
this.dataSet = await this.loadData()
this.updateChart()
this.options.toImageButtonOptions.filename = buildCleanTitle(this.title, this.subfolder)
this.options.toImageButtonOptions.filename = buildCleanTitle(this.cardTitle, this.subfolder)
this.$emit('dimension-resizer', { id: this.cardId, resizer: this.changeDimensions })
this.$emit('isLoaded')
Expand Down
2 changes: 1 addition & 1 deletion src/views/DashBoard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
:datamanager="datamanager"
:style="{opacity: opacity[card.id]}"
:cardId="card.id"
:cardTitle="card.title"
:allConfigFiles="allConfigFiles"
:title="card.title"
@isLoaded="handleCardIsLoaded(card)"
@dimension-resizer="setDimensionResizer"
@titles="setCardTitles(card, $event)"
Expand Down

0 comments on commit d10c1ce

Please sign in to comment.