build: avoid killall(1) for 'make check' #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the multiskkserv tests with slibtool instead of GNU libtool it fails when 'killall src/multiskkserv' fails to find any processes. This is because with slibtool it is a shell wrapper script for 'src/.libs/multiskkserv'. To avoid this issue a more robust 'check.sh' script was added to run the tests and correctly kill the multiskkserv process with both GNU libtool and slibtool. This was reported for Gentoo: https://bugs.gentoo.org/924142
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Feb 21, 2024
Closes: https://bugs.gentoo.org/924142 Upstream-PR: sina-ht/multiskkserv#1 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Feb 21, 2024
Closes: https://bugs.gentoo.org/924142 Upstream-PR: sina-ht/multiskkserv#1 Signed-off-by: orbea <orbea@riseup.net>
sina-ht
approved these changes
Feb 23, 2024
|
Thanks for the review! I made this PR to reference in the Gentoo PR, but I appreciate that even though this code base hasn't been touched in many years that my change was reviewed. :) |
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Feb 23, 2024
Closes: https://bugs.gentoo.org/924142 Upstream-PR: sina-ht/multiskkserv#1 Upstream-Commit: sina-ht/multiskkserv@20983c7 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 16, 2024
Closes: https://bugs.gentoo.org/924142 Upstream-PR: sina-ht/multiskkserv#1 Upstream-Commit: sina-ht/multiskkserv@20983c7 Signed-off-by: orbea <orbea@riseup.net> Closes: #35473 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the multiskkserv tests with slibtool instead of GNU libtool it fails when
killall src/multiskkservfails to find any processes. This is because with slibtool it is a shell wrapper script forsrc/.libs/multiskkserv.To avoid this issue a more robust
check.shscript was added to run the tests and correctly kill the multiskkserv process with both GNU libtool and slibtool.This was reported for Gentoo: https://bugs.gentoo.org/924142