Update ztApi.ts - change default URL of the Local Zerotier URL

[tinola]

I think address http://zerotier:9993 may be a bit misleading, especially for the standalone version installations. My proposition is to use by default (if not specified in .env file ZT_ADDR variable) http://127.0.0.1:9993 which should work everywhere.

[tinola]

This should avoid problem as described here

[sinamics]

ZT_ADDR is not added to docker-compose env as default. Using http://127.0.0.1:9993 as fallback will give error in docker.
We could do something like :

import { isRunningInDocker } from "./docker";

const LOCAL_ZT_ADDR =
	process.env.ZT_ADDR || isRunningInDocker()
		? "http://zerotier:9993"
		: "http://127.0.0.1:9993";

When not docker enviroment use http://127.0.0.1:9993 else http://zerotier:9993

[tinola]

Great! You're absolutely right. That will do trick :)

[sinamics]

Do you want me to add the changes, or will you add them yourself?

[tinola]

Just updated my PR. Please check.

[sinamics]

Perfect.
Just tested in docker and works just fine.

[tinola]

Thanks for cooperation! Then you can merge into main :)

[tinola]

Well... we have to consider to change also in other files for visual experience in webUI, because I still see this:

Grepping for "http://zerotier:9993" I found http://zerotier:9993 in these files as well:

./prisma/migrations/20230811063619_user_options/migration.sql:    "localControllerUrl" TEXT DEFAULT 'http://zerotier:9993',
./prisma/schema.prisma:  localControllerUrl             String?           @default("http://zerotier:9993")
./prisma/seeds/user-option.seed.ts:                                     localControllerUrl: "http://zerotier:9993",
./src/pages/admin/controller/index.tsx:                                                         placeholder: me?.options?.localControllerUrl || "http://zerotier:9993",

excluding auto generated during build.

I think that cruical is src/pages/admin/controller/index.tsx file, but I can be wrong.

Could you add proper conditions?

[sinamics]

i will add a check during the registration if the user is in docker or not and update db accourdingly.

[tinola]

OK, thanks! 👍 But what about existing users?...

[sinamics]

users who already uses ztnet as standalone, has probably already changed this value. I dont want to create a new migration that will force new values in db when they update.

[tinola]

Understood. Basically, I only mean the visual effect in webUI as a placeholder in the screenshot as I pasted above :)

[sinamics]

I have updated the placeholder so the correct value will be displayed

[sinamics]

i will take ta deeper dive into this later. I think there is a potensial bug when using the ZT_ADDR env variable.

[tinola]

You're right. I've the same issue... ztnet stopped to respect ZT_ADDR env variable from .env file.
I thought it only applies to me ;) uff...