Fix deprecation warning seen with ActiveRecord v 7.1 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem --------- With ActiveRecord v7, this gem is still working but it reports a deprecation warning. This is from a Sinatra app with `sinatra-activerecord` version 2.0.2. ``` web | DEPRECATION WARNING: Calling `ActiveRecord::Base.clear_active_connections! is deprecated. Please call the method directly on the connection handler; for example: `ActiveRecord::Base.connection_handler.clear_active_connections!`. (called from load at /Users/jon/.rbenv/versions/2.7.6/bin/rackup:23) ``` solution --------- This PR condititionally calls `clear_active_connections!` off the `connection_handler` for ActiveSupport versions of 7 or greater and retains the old behavior for older versions. tests ----- The test suite here still passes, and I pulled this gem into my app and watched the deprecation message go away.
|
Thanks a lot for the PR! 🙏 LGTM, I will merge and deploy this if the CI passes |
|
@bunnymatic I have created another PR (#129 ) following the code changes here, and manually set environment to "development" in the rake_spec.rb file , I have merged it and released it as v2.0.27 . Thanks for contributing! |
|
perfecto. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
With ActiveRecord v7, this gem is still working but it reports a deprecation warning.
This is from a Sinatra app with
sinatra-activerecordversion 2.0.2.solution
This PR condititionally calls
clear_active_connections!off theconnection_handlerfor ActiveSupport versions of 7 or greater and retains the old behavior for older versions.tests
The test suite here still passes, and I pulled this gem into my app and watched the deprecation message go away.