This repository has been archived by the owner on May 16, 2021. It is now read-only.
ensure Rack::Protection::Base#random_string always outputs 32 characters #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkh
added a commit
that referenced
this pull request
Sep 9, 2013
ensure Rack::Protection::Base#random_string always outputs 32 characters
zzak
pushed a commit
that referenced
this pull request
Aug 12, 2016
ensure Rack::Protection::Base#random_string always outputs 32 characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, authenticity tokens would be either 32 or 64 characters long, depending on the presence of SecureRandom in the environment.
This changes
Rack::Protection::Base#random_stringto always output strings of 32 characters, ensuring that generated authenticity tokens will always have the same length (whether we're usingSecureRandom.hexorKernel.rand).(See here for more discussion.)