This repository has been archived by the owner on May 16, 2021. It is now read-only.
stop warnings on -w #132
Merged
stop warnings on -w #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -369,7 +370,8 @@ def dont_reload(*glob) | |||
|
|
|||
| private | |||
|
|
|||
| attr_reader :register_path | |||
| # attr_reader :register_path warn on -w (private attribute) | |||
| def register_path; @register_path ||= nil; end | |||
There was a problem hiding this comment.
In this case I think we need to change all other instances of @register_path to use this method.
zzak
pushed a commit
to zzak/sinatra-contrib
that referenced
this pull request
Jul 22, 2016
stop warnings on -w
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop warnings on -w about "uninitialized instance variables" and "private attribute?".