Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's a good idea to split base.rb in a file per class? #658

Closed
patriciomacadden opened this issue Mar 6, 2013 · 5 comments
Closed

It's a good idea to split base.rb in a file per class? #658

patriciomacadden opened this issue Mar 6, 2013 · 5 comments
Milestone

Comments

@patriciomacadden
Copy link
Member

One class per file it's a good practice. I don't know if is a requirement that all core classes in sinatra resides in a single file?

Just wondering if would be nice to do this. It's not a big deal if it's not done, but maybe it would be nice.

It's so crazy what I'm saying?

@fr33z3
Copy link

fr33z3 commented Mar 7, 2013

I think it's a good idea.

@guiman
Copy link

guiman commented Mar 7, 2013

👍

@JonRowe
Copy link
Contributor

JonRowe commented Mar 7, 2013

I'm a fan of this idea, but I think there might be a reason it's in one file, @rkh? I'm sure if you had a go at a pull request that @rkh would consider it @patriciomacadden ...

@patriciomacadden
Copy link
Member Author

Of course I'll send a pull request if @rkh thinks it's a good idea. I don't want to do it if it's not.

@rkh
Copy link
Member

rkh commented Mar 8, 2013

No pull request, please. I'm not generally opposed to the idea, thought this has been discussed at length and might be overrated. Esp. since it right now is a big part of the Sinatra flair (main functionality is in one file and yet it's smaller than the readme). As you can see from the milestone, I am meaning to split it up for Sinatra 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants