Isolate classes from Base to separate files #716
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at Sinatra source code, and tried to understand how it works. The first thing I noticed was "there's SO MUCH STUFF in
base.rb
", seriously it's pretty easy to get lost there.I isolated some of the classes from base to separate files up to the point when it would require to fiddle with the project object hierarchy to proceed.
base.rb
has shrunk with ~800 LOC.This is my first attempt at a open source contribution like this, so I will understand if you will consider my efforts pointless.
Edit: The Travis build is failing, but it's not related to my changes as I see it. The errors that Travis throws are related to failure to get a gem, but I didn't touch the Gemfile.
rake spec
gives no failures for my changes.https://travis-ci.org/sinatra/sinatra/jobs/7388775
https://travis-ci.org/sinatra/sinatra/jobs/7388777