Sinatra completely incompatible with HTTP gem.

[krainboltgreene]

The http.gem defines a top level HTTP constant, a module.

Sinatra looks for a top level HTTP constant and calls run on it, regardless of if you want it to do that.

This is pretty weird and I'm going to say, since top level constants (in my opinion) should be reserved for namespaces that the http.gem wins.

Why is Sinatra doing this possibly dangerous thing on a global constant? What if there's an HTTP constant with a .run method that does something the user doesn't want to do?

[krainboltgreene]

Bringing in @tarcieri since it's his gem.

[tarcieri]

Got a link to the relevant Sinatra code?

[krainboltgreene]

Here's an example of the error:

/Users/krainboltgreene/.rvm/gems/ruby-2.1.1/gems/sinatra-1.4.5/lib/sinatra/base.rb:1497:in `start_server': undefined method `run' for HTTP:Module (NoMethodError)
    from /Users/krainboltgreene/.rvm/gems/ruby-2.1.1/gems/sinatra-1.4.5/lib/sinatra/base.rb:1435:in `run!'
    from /Users/krainboltgreene/.rvm/gems/ruby-2.1.1/gems/sinatra-1.4.5/lib/sinatra/main.rb:25:in `block in <module:Sinatra>'

[tarcieri]

Looks like the "handler" might be getting set to HTTP somehow?

https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1435
https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1497

[krainboltgreene]

The primary prefernece issue is here: https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1862

[krainboltgreene]

@tarcieri Yep, based on the preference. The preference by default defines two "servers": "HTTP" and "webrick". It then goes over each of those server "names" and feeds them to Rack::Handler (helpfully swallowing up errors): https://github.com/sinatra/sinatra/blob/master/lib/sinatra/base.rb#L1766

[tarcieri]

What else is HTTP supposed to be besides my gem, especially when it comes to an HTTP server?

[rkh]

I think this is a bug in Rack. It should check for Rack::Handler::HTTP, provided by net-http-server.

The relevant code is in rack/handler.

[krainboltgreene]

Alright, I'll bring it up with them and submit a PR. Thanks!

On Fri, Jun 6, 2014 at 4:07 PM, Konstantin Haase notifications@github.com
wrote:

I think this is a bug in Rack. It should check for Rack::Handler::HTTP,
provided by net-http-server
https://github.com/postmodern/net-http-server/blob/master/lib/rack/handler/http.rb
.

The relevant code is in rack/handler
https://github.com/rack/rack/blob/master/lib/rack/handler.rb.

—
Reply to this email directly or view it on GitHub
#881 (comment).

Kurtis Rainbolt-Greene, Hacker
Software Developer
1631 8th St.
New Orleans, LA
70115

[zzak]

Not sure this is something we can fix in Sinatra, giving it a close.

Please feel free to discuss this issue on Rack.