Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cache-Control header docs [ci skip] #1401

Merged
merged 1 commit into from Feb 22, 2018
Merged

Fix Cache-Control header docs [ci skip] #1401

merged 1 commit into from Feb 22, 2018

Conversation

iguchi1124
Copy link
Contributor

I saw RFC 2616 and RFC 7234(latest...?), response Cache-Control min-stale directive does not exist. So I updated Cache-Control docs.

@namusyaka namusyaka added this to the Beyond milestone Feb 22, 2018
@namusyaka
Copy link
Member

RFC-2616 has existed in the source yet. Why didn't you update another parts?

@iguchi1124
Copy link
Contributor Author

I'm care about min-stale directive which is not exist in RFC. At this time I updated only Cache-Control doc.

@namusyaka
Copy link
Member

The original issue is that min-stale doesn't exist everywhere, makes sense.
However, the change seems not to be enough. For example, according to RFC-7314, a few headers such as max-stale, min-fresh and etc exsit. Could you double-check the docs?

@iguchi1124
Copy link
Contributor Author

max-stale, min-fresh and etc exsit

Isn't it a "Request" Cache-Control specification? I think there are not a kind of "Response" Cache-Control.

@namusyaka
Copy link
Member

Ah sorry, it's my bad. I understood that your change conform the RFC-7314.
However, Sinatra hasn't refer the RFC-7314, but RFC-2616 instead (You can check the link by grepping 2616 inside sinatra repo). I understand thing that should be updated, but it shouldn't be contained in patch-level release, right?
Also, I'd like to update all things at the same time if possible.

Therefore, if you'd like to merge this change, you should remove only min-stale. Don't update RFC version.

@iguchi1124
Copy link
Contributor Author

iguchi1124 commented Feb 22, 2018

Fixed and squashed on this commit! 308e36b

@namusyaka namusyaka modified the milestones: Beyond, v2.0.2 Feb 22, 2018
@namusyaka namusyaka self-requested a review February 22, 2018 12:19
Copy link
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@namusyaka namusyaka merged commit 6c1ed0b into sinatra:master Feb 22, 2018
@iguchi1124 iguchi1124 deleted the cache-control branch February 22, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants