Splitting sinatra/base.rb #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halan
force-pushed
the
splitting-base
branch
2 times, most recently
from
7200c94
to
0271b32
Compare
|
✅ |
Closed
vbrazo
approved these changes
Aug 12, 2019
|
rebased. ❤️ Let's rock! |
vbrazo
reviewed
Aug 21, 2019
There was a problem hiding this comment.
@halan What do you think about adding these error objects in a errors.rb and centralize them there?
module Sinatra
module Errors
# Raised when the server was unable to process the request sent by the client due to invalid syntax
class BadRequest < TypeError
# Raised when a URL is no longer accessible
class NotFound < NameError
end
end
|
Sounds good. I'll take a look. |
|
Top-level constants living in |
|
I agree. |
davidsilveira
approved these changes
Jan 21, 2020
epergo
approved these changes
Apr 24, 2020
|
I did rebase with master and accepted all good suggestions here! Thank you guys. |
|
Will this ever get accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just splits
sinatra/base.rbinto files. The intent here is to do the first step of a refactoring. The next steps can be refactoring each piece separately.Related with #1531