Add TruffleRuby to CI matrix #1751

dentarg · 2022-02-16T22:19:52Z

No description provided.

dentarg · 2022-02-21T22:02:14Z

Maybe @eregon can take a look here? As it now works with MRI and JRuby

olleolleolle · 2022-02-24T15:44:04Z

The Gemfile is sorta not installing very much for Truffle:

   Using rake 13.0.6
  Using bundler 2.2.22
  Using minitest 5.15.0
  Using multi_json 1.15.0
  Using ruby2_keywords 0.0.5
  Using mustermann 1.1.1
  Using rack 2.2.3
  Using rack-protection 3.0.0 from source at `rack-protection`
  Using rack-test 1.1.0
  Using tilt 2.0.10
  Using sinatra 3.0.0 from source at `.`
  Using sinatra-contrib 3.0.0 from source at `sinatra-contrib`
  Using unf_ext 0.0.8
  Using unf 0.1.4
  Using twitter-text 1.14.7
  Using webrick 1.7.0
  Using yard 0.9.27
  Bundle complete! 10 Gemfile dependencies, 17 gems now installed.
  Bundled gems are installed into `./vendor/bundle`
  Took  24.25 seconds

epergo · 2022-02-24T15:49:06Z

Probably because almost every gem is under RUBY_ENGINE == "ruby" https://github.com/sinatra/sinatra/blob/master/Gemfile#L29 We have to update it so dependencies are installed for truffle

eregon · 2022-02-24T16:11:29Z

Right that line should probably be unconditional.

FWIW, if RUBY_ENGINE in Gemfile is kind of an anti-pattern, gem 'foo', platforms: :ruby can be used to specify a gem which needs C extensions and is not installed on JRuby & on Windows: https://bundler.io/man/gemfile.5.html#PLATFORMS
And there is a block form: https://bundler.io/man/gemfile.5.html#BLOCK-FORM-OF-SOURCE-GIT-PATH-GROUP-and-PLATFORMS

Rubinius is dead AFAIK so that could probably be removed entirely from the Gemfile.

olleolleolle · 2022-02-24T16:16:31Z

#1756 Thanks for the reminder, here is "drop rbx".

olleolleolle · 2022-02-24T17:08:19Z

OK! #1757 is "use platforms:"!

olleolleolle · 2022-02-24T17:15:19Z

(Gotta rebase, then we'll know more!)

jkowens · 2022-02-24T17:16:32Z

@olleolleolle ah that's right. If I close/re-open the PR does that pick up the latest changes in master?

olleolleolle · 2022-02-24T17:18:20Z

@olleolleolle ah that's right. If I close/re-open the PR does that pick up the latest changes in master?

@dentarg is probably awake enough to do that for us.

eregon · 2022-02-24T17:50:18Z

I commented on #1757 there are a few tweaks needed to let the gems install on TruffleRuby.

eregon · 2022-02-24T17:53:31Z

I (or maybe @bjfish) could take a shot e.g. tomorrow at making a PR changing whatever is needed (e.g., the Gemfile) to make the gems install correctly on truffleruby and the tests pass, that may be easier.

olleolleolle · 2022-02-24T19:19:54Z

(Thanks, dentarg!)

/home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:653:in `const_missing': uninitialized constant ThreadSafe::Cache (NameError)

[To redirect Truffle log output to a file use one of the following options:
* '--log.file=<path>' if the option is passed using a guest language launcher.
* '-Dpolyglot.log.file=<path>' if the option is passed using the host Java launcher.
* Configure logging using the polyglot embedding API.]
[ruby] WARNING: Encoding.find('locale') is US-ASCII, this often indicates that the system locale is not set properly. Set LANG=C and LC_ALL=C to suppress this warning (but some things might break).
/home/runner/.rubies/truffleruby-22.0.0.2/lib/patches/thread_safe.rb:3: warning: loading in progress, circular require considered harmful - /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/thread_safe-0.3.6/lib/thread_safe.rb
/home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:653:in `const_missing': uninitialized constant ThreadSafe::Cache (NameError)
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:653:in `init_loaded_zones'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:655:in `<class:Timezone>'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:46:in `<module:TZInfo>'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:5:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo.rb:31:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/values/time_zone.rb:1:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/core_ext/time/conversions.rb:2:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/core_ext/time/calculations.rb:2:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/core_ext/time.rb:2:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/time.rb:10:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-5.1.7/lib/active_support/core_ext/hash/conversions.rb:2:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/test/helper.rb:34:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/test/asciidoctor_test.rb:1:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21:in `block in <main>'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `select'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!
Command failed with status (1)
/home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
<internal:core> core/kernel.rb:376:in `load'
<internal:core> core/kernel.rb:376:in `load'
<internal:core> core/kernel.rb:376:in `load'
<internal:core> core/kernel.rb:376:in `load'
<internal:core> core/kernel.rb:376:in `load'
<internal:core> core/kernel.rb:376:in `load'
/home/runner/.rubies/truffleruby-22.0.0.2/bin/bundle:42:in `<main>'

Is this comment related to this? And the existence of a gems/thread_safe-0.3.6/lib/thread_safe.rb which may or may not be the same thing as the concurrent-ruby thing?

ruby-concurrency/thread_safe#23 (comment)

olleolleolle · 2022-02-24T19:29:21Z

Perhaps #1758 will make more gems available to Truffleruby?

eregon · 2022-02-24T19:42:36Z

thread_safe is deprecated since a while and never had TruffleRuby suport, unlike concurrent-ruby which works fine.
It seems to be tzinfo 1.2.9 depending on it:

    tzinfo (1.2.9)
      thread_safe (~> 0.1)

Would it possible to update to a newer tzinfo which nowadays depends on concurrent-ruby? (https://github.com/tzinfo/tzinfo/blob/master/tzinfo.gemspec)

olleolleolle · 2022-02-24T19:45:53Z

@eregon Ah, yes, the venerable

activesupport (5.1.7)
  concurrent-ruby (~> 1.0, >= 1.0.2)
  i18n (>= 0.7, < 2)
  minitest (~> 5.1)
  tzinfo (~> 1.1)

I will make that update in the "More careful Gemfile".

Try to get a tzinfo dependency which is dependent on concurrent-ruby, so that good things happen, instead of /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/tzinfo-1.2.9/lib/tzinfo/timezone.rb:653:in `const_missing': uninitialized constant ThreadSafe::Cache (NameError) For context, see: sinatra#1751 (comment)

olleolleolle · 2022-02-25T05:23:25Z

@eregon Now, we have arrived somewhere more interesting, I think. Here is a fragment:

/home/runner/.rubies/truffleruby-22.0.0.2/lib/patches/concurrent/atomic/atomic_reference.rb:8: warning: loading in progress, circular require considered harmful - gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/atomic/atomic_reference.rb
gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/configuration.rb:89:in const_missing': uninitialized constant Concurrent::AtomicReference (NameError) from /gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/configuration.rb:89:in module:Concurrent'

/home/runner/.rubies/truffleruby-22.0.0.2/lib/patches/concurrent/atomic/atomic_reference.rb:8: warning: loading in progress, circular require considered harmful - /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/atomic/atomic_reference.rb
/home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/configuration.rb:89:in `const_missing': uninitialized constant Concurrent::AtomicReference (NameError)
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/configuration.rb:89:in `<module:Concurrent>'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent/configuration.rb:11:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/concurrent-ruby-1.1.9/lib/concurrent-ruby/concurrent.rb:4:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-6.1.4.6/lib/active_support/logger_thread_safe_level.rb:5:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-6.1.4.6/lib/active_support/logger_silence.rb:5:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-6.1.4.6/lib/active_support/logger.rb:3:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/activesupport-6.1.4.6/lib/active_support.rb:29:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rabl-0.15.0/lib/rabl.rb:1:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/test/rabl_test.rb:4:in `<top (required)>'
	from <internal:core> core/kernel.rb:234:in `gem_original_require'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21:in `block in <main>'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `select'
	from /home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!
Command failed with status (1)

I note that perhaps this is related?
https://github.com/ruby-concurrency/concurrent-ruby/pull/907/files

eregon · 2022-02-25T15:19:34Z

I could repro it locally, also with latest TruffleRuby, I filed oracle/truffleruby#2605

eregon · 2022-02-25T15:22:37Z

BTW this warning:

[To redirect Truffle log output to a file use one of the following options:
* '--log.file=<path>' if the option is passed using a guest language launcher.
* '-Dpolyglot.log.file=<path>' if the option is passed using the host Java launcher.
* Configure logging using the polyglot embedding API.]
[ruby] WARNING: Encoding.find('locale') is US-ASCII, this often indicates that the system locale is not set properly. Set LANG=C and LC_ALL=C to suppress this warning (but some things might break).

is caused by:

sinatra/Rakefile

Lines 27 to 28 in 0309bbb

    
           ENV['LANG'] = 'C' 
        
           ENV.delete 'LC_CTYPE'

It'd be great to remove that as that can break lots of things in very subtle ways (but doesn't seem the cause of the issue linked above).

This is related to work happening for sinatra#1751 (comment)

This is related to sinatra#1751 (comment)

olleolleolle · 2022-02-26T09:58:09Z

@dentarg Right, now the warning-removing for Truffleruby is applied. Lots of keeping up, for this branch.

olleolleolle · 2022-03-05T22:42:22Z

Speculating: Ah, is rainbows the gem, now not yet added with a platforms: including :ruby? Hm, no, that's the used setting:

https://github.com/sinatra/sinatra/blob/master/Gemfile#L32

loading
starting
/home/runner/work/sinatra/sinatra/vendor/bundle/truffleruby/3.0.2.22.0.0/gems/rack-2.2.3/lib/rack/handler.rb:45:in `pick': Couldn't find handler for: rainbows. (LoadError)
	from /home/runner/work/sinatra/sinatra/lib/sinatra/base.rb:1489:in `run!'
	from /home/runner/work/sinatra/sinatra/lib/sinatra/main.rb:45:in `block in <module:Sinatra>'

https://github.com/rack/rack/blob/main/lib/rack/handler.rb#L30-L42

eregon · 2022-03-06T11:09:13Z

I or @bjfish will take a look

Default is 360 minutes, ain't nobody got time for that. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

TruffleRuby wasn't able to bundle in 5 minutes: https://github.com/sinatra/sinatra/runs/6081844135?check_suite_focus=true

kares mentioned this pull request Feb 21, 2022

CI: let's roll tests with JRuby #1755

Merged

jkowens closed this Feb 21, 2022

jkowens reopened this Feb 21, 2022

jkowens changed the title ~~Add JRuby and TruffleRuby to CI matrix~~ Add TruffleRuby to CI matrix Feb 21, 2022

dentarg marked this pull request as ready for review February 21, 2022 21:58

olleolleolle mentioned this pull request Feb 24, 2022

Use Bundler "platforms" in Gemfile #1757

Merged

eregon mentioned this pull request Feb 25, 2022

require Primitive.get_original_require(__FILE__) not working for Concurrent::AtomicReference patch oracle/truffleruby#2605

Closed

olleolleolle added a commit to olleolleolle/sinatra that referenced this pull request Feb 25, 2022

WIP: Try to turn off ENV vars that disrupt Truffleruby

2db61fd

This is related to work happening for sinatra#1751 (comment)

olleolleolle mentioned this pull request Feb 25, 2022

Stop setting LANG=C and not removing LC_TYPE ENV vars; that disrupt Truffleruby #1760

Merged

olleolleolle added a commit to olleolleolle/sinatra that referenced this pull request Feb 25, 2022

Turn off ENV vars that disrupt Truffleruby in test

440b59e

This is related to sinatra#1751 (comment)

dentarg force-pushed the add-jvm-rubies-to-ci branch from 2345036 to ba34f1e Compare February 26, 2022 10:09

bjfish mentioned this pull request Mar 1, 2022

Avoid adding project directory to the load path for tests #1765

Merged

jkowens closed this Mar 5, 2022

jkowens reopened this Mar 5, 2022

dentarg force-pushed the add-jvm-rubies-to-ci branch from ba34f1e to 900dc7a Compare March 5, 2022 23:04

dentarg closed this Apr 19, 2022

dentarg reopened this Apr 19, 2022

dentarg force-pushed the add-jvm-rubies-to-ci branch from 1afd296 to ada61d0 Compare April 19, 2022 20:17

jkowens force-pushed the master branch from 28e45c3 to d61c8a8 Compare July 15, 2022 03:37

dentarg force-pushed the add-jvm-rubies-to-ci branch from ada61d0 to d5ec7d3 Compare July 19, 2022 22:17

dentarg added 3 commits July 20, 2022 00:23

Timeout CI after 5 minutes

3b7ce42

Default is 360 minutes, ain't nobody got time for that. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

Add JRuby (head) and TruffleRuby to CI matrix

59485f1

Timeout CI after 15 minutes

d682b00

TruffleRuby wasn't able to bundle in 5 minutes: https://github.com/sinatra/sinatra/runs/6081844135?check_suite_focus=true

dentarg force-pushed the add-jvm-rubies-to-ci branch from d5ec7d3 to d682b00 Compare July 19, 2022 22:27

dentarg added 2 commits July 20, 2022 00:30

setup-ruby may fail as it runs bundle install

a09c591

Be explict about rack version

1df3e9b

jkowens merged commit 98e5006 into sinatra:master Jul 19, 2022

dentarg deleted the add-jvm-rubies-to-ci branch July 20, 2022 04:39

This was referenced Jul 20, 2022

Get tests to pass on truffleruby-22 #1798

Closed

Get tests to pass on truffleruby-head #1799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TruffleRuby to CI matrix #1751

Add TruffleRuby to CI matrix #1751

dentarg commented Feb 16, 2022 •

edited

dentarg commented Feb 21, 2022

olleolleolle commented Feb 24, 2022

epergo commented Feb 24, 2022

eregon commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022

olleolleolle commented Feb 24, 2022

jkowens commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022

eregon commented Feb 24, 2022

eregon commented Feb 24, 2022

olleolleolle commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022

eregon commented Feb 24, 2022

olleolleolle commented Feb 24, 2022 •

edited

olleolleolle commented Feb 25, 2022 •

edited

eregon commented Feb 25, 2022

eregon commented Feb 25, 2022

olleolleolle commented Feb 26, 2022

olleolleolle commented Mar 5, 2022 •

edited

eregon commented Mar 6, 2022

Add TruffleRuby to CI matrix #1751

Add TruffleRuby to CI matrix #1751

Conversation

dentarg commented Feb 16, 2022 • edited

dentarg commented Feb 21, 2022

olleolleolle commented Feb 24, 2022

epergo commented Feb 24, 2022

eregon commented Feb 24, 2022 • edited

olleolleolle commented Feb 24, 2022 • edited

olleolleolle commented Feb 24, 2022

olleolleolle commented Feb 24, 2022

jkowens commented Feb 24, 2022 • edited

olleolleolle commented Feb 24, 2022

eregon commented Feb 24, 2022

eregon commented Feb 24, 2022

olleolleolle commented Feb 24, 2022 • edited

olleolleolle commented Feb 24, 2022

eregon commented Feb 24, 2022

olleolleolle commented Feb 24, 2022 • edited

olleolleolle commented Feb 25, 2022 • edited

eregon commented Feb 25, 2022

eregon commented Feb 25, 2022

olleolleolle commented Feb 26, 2022

olleolleolle commented Mar 5, 2022 • edited

eregon commented Mar 6, 2022

dentarg commented Feb 16, 2022 •

edited

eregon commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022 •

edited

jkowens commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022 •

edited

olleolleolle commented Feb 24, 2022 •

edited

olleolleolle commented Feb 25, 2022 •

edited

olleolleolle commented Mar 5, 2022 •

edited