Remove old markdown gems #1762
Merged
Remove old markdown gems #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epergo
commented
Feb 27, 2022
| markdown_templates = Tilt.lazy_map['md'].map { |klass, _require_path| klass } | ||
|
|
||
| markdown_templates.each do |template_name| | ||
| [ |
There was a problem hiding this comment.
Instead of loading all possible markdown engines from Tilt, we require those that we support
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1759
Removing tests/support for bluecloth and maruku because they aren't actively maintained. Redcarpet and kramdown are better alternatives.
This doesn't remove support completely because Tilt is the one implementing their interface in the first place, here we are stopping to run tests for these old gems that aren't probably used anymore but users can still install and use them.