Add Sinatra::HamlHelpers to sinatra-contrib
#1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haml 6 retained some helpers methods, but only for Rails: https://github.com/haml/haml/blob/v6.2.3/lib/haml/rails_helpers.rb It is possible to use those, if you monkey-patch |
Brings back three helpers from Haml 5: https://github.com/haml/haml/blob/v5.2.2/lib/haml/helpers.rb#L294-L357
[ci skip]
Should be safer, so they accidentally aren't run and we don't see that.
dentarg
force-pushed
the
contrib/haml-helpers
branch
from
252a50d
to
6984693
Compare
[ci skip] Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
|
Thanks for keeping this useful! |
So it is loaded by require "sinatra/contrib/all".
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back three helpers from Haml 5:
https://github.com/haml/haml/blob/v5.2.2/lib/haml/helpers.rb#L294-L357