Feature/enable options in static method #790

Merged
merged 3 commits into from Feb 21, 2014

Conversation

Projects
None yet
3 participants

This change enables the use of options with the static! method. This is useful if you wish to return status content with alternate status codes, etc.

Blake Watters and others added some commits Jul 31, 2013

Blake Watters Add support for supplying options to `static!`, enabling the use of c…
…ustom status codes, etc.

Add test case highlighting the breakage when attempting to use `send_file` with a specific status code. refs sinatra/sinatra#749
8fb79ac
@yegortimoshenko yegortimoshenko #send_file indifferent :status option d8876cf
@yegortimoshenko yegortimoshenko Use #Integer (thank you, @rkh) 816c081

I suppose it is better to recreate this pull request, there are two my commits merged already. For example, you may delete your fork and refork this repo one more time and make a branch and repeat your changes.

Nevertheless, I like this feature, find it useful. 👍

Owner

rkh commented Oct 21, 2013

I assigned this to the 1.5.0 milestone, which I'll switch master over to soon. If you're having issues cleaning up the PR, don't worry, I can cherry-pick the commit.

@rkh rkh added a commit that referenced this pull request Feb 21, 2014

@rkh rkh Merge pull request #790 from GateGuru/feature/enable-options-in-stati…
…c-method

Feature/enable options in static method
faf2efc

@rkh rkh merged commit faf2efc into sinatra:master Feb 21, 2014

1 check passed

default The Travis CI build passed
Details

@rkh rkh added a commit that referenced this pull request Sep 11, 2015

@rkh rkh Merge pull request #790 from GateGuru/feature/enable-options-in-stati…
…c-method

Feature/enable options in static method
e613147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment