Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonTypeBuilder#Record not passing on options #739

Closed
gregerolsson opened this issue Jan 20, 2024 · 1 comment
Closed

JsonTypeBuilder#Record not passing on options #739

gregerolsson opened this issue Jan 20, 2024 · 1 comment

Comments

@gregerolsson
Copy link

Options object passed to JsonTypeBuilder#Record is not passed on to free Record function

This prevents [Kind]: "Record" types from having $id, title, and so on.

I can make a PR if you prefer, but since its just a 1-liner fix perhaps it can be sorted while you're doing other changes.

Oh, and thanks for a fantastic library ❤️

@sinclairzx81
Copy link
Owner

@gregerolsson Hi,

Thanks for reporting! Have published a fix on 0.32.12 and written option assignment tests to try and catch missed option passing in future (during refactors, forgetting to pass in the options when refactoring has been a common oversight, they're easy to forget!)

All the best!
S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants