Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeDuplicates option to Defaults.publisher(keys...) and Defaults.publisherAll() #43

Closed
sindresorhus opened this issue Apr 15, 2020 · 1 comment
Closed

Add removeDuplicates option to Defaults.publisher(keys...) and Defaults.publisherAll() #43

sindresorhus opened this issue Apr 15, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Apr 15, 2020 •
edited
Loading

Since these publisher are a combination of publishers, users cannot use . removeDuplicates() directly on these publishers, but we can do so internally.

Should it be true by default?
@sindresorhus sindresorhus added the enhancement New feature or request label Apr 15, 2020
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 24, 2020
@IuriiIaremenko IuriiIaremenko mentioned this issue Feb 2, 2021
Merged
@sindresorhus
Copy link
Owner Author

I have decided not to do this.

@sindresorhus sindresorhus removed the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Nov 19, 2022
Repository owner deleted a comment from issuehunt-oss bot Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sindresorhus