Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check for natively supported values #51

Closed
sindresorhus opened this issue Jun 10, 2020 · 1 comment
Closed

Improve check for natively supported values #51

sindresorhus opened this issue Jun 10, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 10, 2020 •
edited

https://github.com/apple/swift-corelibs-foundation/blob/ef6f96ee82ea0f54252071c0ecadf5f01be9aecc/Foundation/UserDefaults.swift#L26-L64

Seems we could also support NSNumber and various Int* types.

Even arrays of values (#47).

We could also adopt the approach of using a protocol to define the natively supported types: https://www.vadimbulavin.com/advanced-guide-to-userdefaults-in-swift/
@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Jun 10, 2020
@hank121314 hank121314 mentioned this issue Dec 22, 2020
Merged
@hank121314 hank121314 mentioned this issue May 17, 2021
Closed
@sindresorhus
Copy link
Owner Author

Fixed by #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sindresorhus