Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash report #42

Closed
sindresorhus opened this issue Oct 22, 2018 · 7 comments
Closed

Crash report #42

sindresorhus opened this issue Oct 22, 2018 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

In Organizer in Xcode, I see some users are getting a crash at:

https://github.com/sindresorhus/gifski-app/blob/eac104f38a1956351d1265b7af7d456c95c31bfc/Gifski/MainWindowController.swift#L124

But there's no error message, so it's hard to guess what the issue is.

This crash has been reported for every version of Gifski since it was first released.

This is what I'm seeing in Xcode:

screen shot 2018-10-22 at 10 49 17

Is there anything we can do to improve the logging of this error? I assumed fatalError would include the actual error message, but it seems not. At least not in the crash report we get from Apple.

D3n6t7-Uxh_FcdK-IatJgq.xccrashpoint.zip

@sindresorhus sindresorhus added the help wanted Extra attention is needed label Oct 22, 2018
@LarsJK
Copy link
Contributor

LarsJK commented Oct 22, 2018

@sindresorhus
Copy link
Owner Author

That guide is for iOS. Fabrics Crashlytics supported macOS, but Google has given no indication of macOS support for Firebase Crashlytics. I also don't trust Google.

@LarsJK
Copy link
Contributor

LarsJK commented Oct 24, 2018

What about logging the error with SwiftyBeaver?

@sindresorhus
Copy link
Owner Author

That could be an option, but how would we get the logs? We would still have to have them uploaded somewhere.

@LarsJK
Copy link
Contributor

LarsJK commented Oct 24, 2018

I've used their cloud platform, and the Mac app to read logs before. Works pretty good.

sindresorhus added a commit that referenced this issue Oct 26, 2018
Related to #42
@sindresorhus
Copy link
Owner Author

sindresorhus commented Oct 26, 2018

SwiftyBeaver looks good for logging, but it doesn't do automatic crash reporting. I went with Fabric Crashlytics. It's still operational even with the new Firebase Crashlytics.

@sindresorhus
Copy link
Owner Author

This was fixed by 833fd28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants