-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Show in Finder
button
#48
Comments
@issuehuntfest has funded $200.00 to this issue. See it on IssueHunt |
Looks a bit uneven. Should probably be centered. From the linked discussion:
It should also have a proxy icon that can be dragged. |
Okay, I will see what I can do about this. |
@sentialx has submitted a pull request. See it on IssueHunt |
@sentialx Yes, but the icon should be a little bit larger and I think we should go with what @kornelski shows in #48 (comment), with the size below the title and in smaller font. The font should also be slightly bolder and lighter. |
Why would it? For me then it looks like I'm dragging out an alias of the file. I do agree we should make it clearer somehow that it can be dragged. |
The problem with For reference, here's how they look (top and bottom icon): Maybe we could find a looking glass icon on https://thenounproject.com/ that would fit with the share icon. Or do something else. I'm open to ideas. |
@sindresorhus Maybe we could pulse the scale of the image view and add a tooltip that it's draggable? |
Yeah, let's try with some pulsating first and see how it feels. |
Maybe you could animate the icon as dropping into the window? Give it some physical motion so that it doesn't feel attached to the window. |
Fixes #48 Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus has rewarded $180.00 to @sentialx. See it on IssueHunt
|
An initial version was added in #43, but it could be improved. See the feedback given there.
The text was updated successfully, but these errors were encountered: