Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Show in Finder button #48

Closed
sindresorhus opened this issue Jan 17, 2019 · 16 comments
Closed

Improve the Show in Finder button #48

sindresorhus opened this issue Jan 17, 2019 · 16 comments
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Jan 17, 2019

Issuehunt badges

An initial version was added in #43, but it could be improved. See the feedback given there.

sentialx earned $200.00 by resolving this issue!

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2019
@IssueHuntBot
Copy link

@issuehuntfest has funded $200.00 to this issue. See it on IssueHunt

@sentialx
Copy link
Contributor

Would it be okay?

@sindresorhus
Copy link
Owner Author

Looks a bit uneven. Should probably be centered.


From the linked discussion:

to show a proxy icon (an icon that and acts like a Finder icon: can be dragged to other apps and double clicked)

It should also have a proxy icon that can be dragged.

@sentialx
Copy link
Contributor

Okay, I will see what I can do about this.

@sindresorhus
Copy link
Owner Author

Here's a quick mockup of what I have in mind. Feedback wanted.

gifski-share-view-mockup

The thing in the middle is a file icon (proxy icon) that is draggable.

I would also like to see the system Share button being placed somewhere there too, to able to quickly share the GIF.

@kornelski
Copy link
Collaborator

Maybe Finder's alias arrow would make it clearer that this is a proxy icon? alias arrow

There's also NSRevealFreestandingTemplate named image for a loupe icon that means revealing in Finder. I'm not sure if it's necessary, but it's an option if you'd like more compact UI or avoid words.

@kornelski
Copy link
Collaborator

Finder shows size underneath the file name, in a smaller font

screenshot 2019-01-25 at 23 13 49

@sentialx
Copy link
Contributor

Is this what you wanted? The file size and the name are not real. Of course I will get the file data, but I was focusing on the proxy icon. See how it works

@IssueHuntBot
Copy link

@sentialx has submitted a pull request. See it on IssueHunt

@sindresorhus
Copy link
Owner Author

sindresorhus commented Jan 29, 2019

@sentialx Yes, but the icon should be a little bit larger and I think we should go with what @kornelski shows in #48 (comment), with the size below the title and in smaller font. The font should also be slightly bolder and lighter.

@sindresorhus
Copy link
Owner Author

Maybe Finder's alias arrow would make it clearer that this is a proxy icon?

Why would it? For me then it looks like I'm dragging out an alias of the file.

I do agree we should make it clearer somehow that it can be dragged.

@sindresorhus
Copy link
Owner Author

There's also NSRevealFreestandingTemplate named image for a loupe icon that means revealing in Finder. I'm not sure if it's necessary, but it's an option if you'd like more compact UI or avoid words.

The problem with NSRevealFreestandingTemplate is that it cannot really be used in a button, but the share icon should. It's probably best if the two buttons, "reveal" and "share", are on the same vertical line, below the icon, so would be best if they looked the same.

For reference, here's how they look (top and bottom icon):

screen shot 2019-01-29 at 21 14 06

Maybe we could find a looking glass icon on https://thenounproject.com/ that would fit with the share icon. Or do something else. I'm open to ideas.

@sentialx
Copy link
Contributor

@sindresorhus Maybe we could pulse the scale of the image view and add a tooltip that it's draggable?

@sindresorhus
Copy link
Owner Author

Yeah, let's try with some pulsating first and see how it feels.

@kornelski
Copy link
Collaborator

Maybe you could animate the icon as dropping into the window? Give it some physical motion so that it doesn't feel attached to the window.

sindresorhus added a commit that referenced this issue Mar 10, 2019
Fixes #48 

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@IssueHuntBot
Copy link

@sindresorhus has rewarded $180.00 to @sentialx. See it on IssueHunt

  • 💰 Total deposit: $200.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $20.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants