Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm quitting the app during conversion #134

Merged
merged 2 commits into from Sep 16, 2019
Merged

Conversation

sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Sep 14, 2019

To prevent people accidentally quitting.

Screenshot 2019-09-14 at 16 07 02

The conversion continues behind it.

The wording is taken from the Photos app when exporting:

image

Gifski/AppDelegate.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@sunshinejr sunshinejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one 👍

@sindresorhus sindresorhus merged commit cf0f6eb into master Sep 16, 2019
@sindresorhus sindresorhus deleted the confirm-quit branch September 16, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants