New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quick Look shortcut to the conversion completed view #79
Merged
sindresorhus
merged 12 commits into
sindresorhus:master
from
sunshinejr:feature/quick_look
May 21, 2019
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
08d6b38
[QuickLook] Add main menu bar item
sunshinejr 8f8ffa3
[QuickLook] Add handling of the quickLook action to the main window
sunshinejr 3566607
Remove redundant self in MainWindowController
sunshinejr 236effa
conversionCompleted -> isConversionCompleted
sunshinejr 97d1d49
Quick Look... -> Quick Look + add separator in between
sunshinejr 56028ad
Move QLPreviewPanel logic to ConversionCompletedView
sunshinejr 6d9ee90
Extract QLPreviewPanel.toggle() method
sunshinejr 9f5ebd5
Update ConversionCompletedView.swift
sindresorhus 7f3f3fe
Move quickLook actions in Conversion view to QL extension
sunshinejr 5e49ecf
NSView.boundsInScreenCoordinates & DraggableFile.imageView extensions
sunshinejr bd2415f
Clean up responder chain
sunshinejr 6c4b578
Update ConversionCompletedView.swift
sindresorhus File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpinned & pinned the action again and so the id regenerated 🤕