Add some colors to the initial view #88
Conversation
|
Nice. These elements look like they could be animated (e.g. either open on startup, or close after you drop something). |
|
@kornelski Yes, that would be cool. |
sindresorhus
force-pushed
the
improved-start-view
branch
from
b2ffc7d
to
cd2b9a1
Compare
sindresorhus
changed the title
| @@ -67,6 +67,11 @@ class DropView: SSView { | |||
| override func draw(_ dirtyRect: CGRect) { | |||
| super.draw(dirtyRect) | |||
|
|
|||
| // We only draw it when the drop view controller is the main view controller. | |||
There was a problem hiding this comment.
what do you think about extracting it to a backgroundImage property of a VideoDropView and then only pass it in the controllers that do not hide the text label as well?
There was a problem hiding this comment.
I agree that would be technically better. I'm just not sure it's worth the extra complexity. VideoDropViewController is pushed in many places. Would mean a lot of duplicate code for the same result. This is only a temporary thing anyway. I'll rewrite it for SwiftUI with animations later this year.
There was a problem hiding this comment.
yeah, agree there would be some extra cost for that - I was also thinking about 2 classes, one that would be invisible and one with text & background, but that would be an excellent one for SwiftUI component composition
The initial view is a bit boring. This idea might be too much, but at least it could start a discussion.
I want to do something with the text too, but haven't decided what yet. Ideas welcome.
The color scheme is not optimal, ideally, I want to use the colors used in #25 (comment), but this will do for now.
And would be super cool if the lines would animate out when the conversion starts.
And if they would move a little bit when you drag in a file.
Before
After