-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the KeyboardShortcut Recorder still gets the focus by default in certain cases #145
Comments
🙏️ |
@sindresorhus still getting the issue for that one. (the closing the Settings window issue is fixed.) anything i can do to help troubleshoot? |
I'm unable to reproduce this with the latest version together with Plash. Are you able to reproduce in Plash? If it's only reproducible in your app, can you try replacing b878f81#diff-41fc3abd80062ae3c8634038c89a3495bcd1d2455c1ff5cd5aa022f3409c6d8dR146-R149 with: if #available(macOS 13, *) {
Task {
try? await Task.sleep(for: .seconds(0.5))
canBecomeKey = true
}
} |
will do in a couple of hours. will try the latest version of Plash, my apps, the replacement you propose, and may create a bare repo showing the issue if necessary. thanks. |
so i guess it's something in my apps. will dig. and will try to make a project from scratch and see. |
dumping what i'm finding: if i show my Settings window from launching the app again, or through pressing |
i made a project from scratch with bare minimum code and the issue doesn't show up. so it has to be on my side. i'll try to figure out why, and i'll update here for reference. but as far as you're concerned, all is good on your side. thanks again Sindre! |
found it. it's coming from that func in my AppDelegates: func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
NSApp.hide(self)
return false
} for whatever reason this causes the issue with the KeyboardShortcuts Recorder. will see what i can do now from my side. P.S.: this code is so that when closing the Settings of my apps, the focus goes back to the previous app rather than being in the limbo. |
this doesn't happen when you first show your Settings dialog, but it happens at a later stage, if you start fingering the Recorder. this can be easily seen in the latest version of Plash. that will cause the issue reported in #144. see below:
ScreenFlow.mp4
The text was updated successfully, but these errors were encountered: