Add method to remove all handlers #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required if your keyboard shortcut names are dynamic (eg. they depend on user content) and you want to reset the handlers before re-creating them to avoid having multiple handlers for the same shortcut.
sindresorhus
reviewed
Jan 8, 2021
| @@ -45,6 +45,16 @@ public enum KeyboardShortcuts { | |||
|
|
|||
| // TODO: Should remove user defaults too. | |||
| } | |||
|
|
|||
| /** | |||
| Remove all handlers receiving keyboard shortcuts events. | |||
There was a problem hiding this comment.
Can you also document your use-case for it as mention in the PR description? It's not always clear to users what they would use something for and one or more use-cases can help them realize.
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required if your keyboard shortcut names are dynamic (eg. they depend on user content) and you want to reset the handlers before re-creating them to avoid having multiple handlers for the same shortcut.