Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German localization #49

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Add German localization #49

merged 3 commits into from
Jun 7, 2021

Conversation

Maschina
Copy link
Contributor

@Maschina Maschina commented Jun 6, 2021

No description provided.

@Maschina Maschina changed the title Add German localization (resolves #48) Add German localization Jun 6, 2021
D4rthR4tz3
D4rthR4tz3 suggested changes Jun 6, 2021
View reviewed changes
Copy link
Contributor

@D4rthR4tz3 D4rthR4tz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small changes are necessary. I've added some suggestions. 🙂

Sources/KeyboardShortcuts/Localization/de.lproj/Localizable.strings Outdated Show resolved Hide resolved
Sources/KeyboardShortcuts/Localization/de.lproj/Localizable.strings Outdated Show resolved Hide resolved
Sources/KeyboardShortcuts/Localization/de.lproj/Localizable.strings Outdated Show resolved Hide resolved
@robinscholz
Copy link

It should be … (single glyph) instead of ... (three glyphs)

Maschina and others added 2 commits June 6, 2021 20:55
@Maschina @D4rthR4tz3
Apply suggestions from code review
e51040e 
Co-authored-by: Sven Kannenberg <sven.kannenberg@googlemail.com>
@Maschina
Update Localizable.strings
dad11fe
@sindresorhus sindresorhus merged commit 701e154 into sindresorhus:main Jun 7, 2021
@sindresorhus
Copy link
Owner

Thanks, everyone :)

@sindresorhus sindresorhus mentioned this pull request Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas left review comments

@alexander-heimbuch alexander-heimbuch alexander-heimbuch left review comments

@D4rthR4tz3 D4rthR4tz3 D4rthR4tz3 requested changes

@staabm staabm staabm approved these changes

@jdreesen jdreesen jdreesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Maschina @robinscholz @sindresorhus @staabm @jdreesen @rejas @alexander-heimbuch @D4rthR4tz3