Fix .setShortcut() crashing when called from a NSBackgroundActivityScheduler task
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@leits This seems to be a bug in Xcode/macOS. When googling, I found some other similar cases. It turns out the issue only happens when running your app from Xcode. Not when archiving, even if you archive a debug build. I have added a workaround in 01feaab. It seems to work for me. Your app no longer crashes. Can you try it out and let me know if it fixes it for you? |
sindresorhus
changed the title
.setShortcut() crashing when called from a NSBackgroundActivityScheduler task
|
Yeah, looks like it's working now. Thanks! |
|
Thanks, @sindresorhus !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8