-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex viewer #31
Hex viewer #31
Conversation
Thanks for working on this! This is already looking pretty good.
|
- macOS only - extract extra into to helper property - appease the SwiftLint gods - simplify HexView.Coordinator
When either the selected type changes or there's new data on the pasteboard, force the contents view to reset, thereby losing selection state
I took a quick look at this in instruments, and from what I can tell there's an identical spike when showing the text view as showing the hex view. I'm reasonably confident that this is down to retrieving the |
Besides the hiccup when showing large datas (like images), all the other feedback has been addressed, including adding the ⌘1 and ⌘2 switcher in the View menu. 😃 |
(I also confirmed that the branch builds cleanly for iOS) |
Looks great 🙌 |
Update submitted. |
This adds a hex viewer to Pasteboard Viewer and fixes #24.
This uses the HexFiend framework to add a hex viewer to the app, which can be accessed by toggling a picker in the toolbar.
Some things to note:
package
branch of the HexFiend project, as that is the branch that adds a Package.swift file. It is technically unreleased, although it appears to be fully functional.