Improve macOS 11 compatibility #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this, currently the toolbarItems style cuts a bit of the text in Big Sur. I suppose you are aware.
To be more specific, I see this with version 1.0.1. |
|
This is what I see on beta 5 with this PR (ignore the missing icons):
|
Yep, that looks better. Without the PR it tries to show it inline with the window controls on the left, resulting in a funky look. |
dezinezync
pushed a commit
to dezinezync/Preferences
that referenced
this pull request
Dec 17, 2022
dezinezync
pushed a commit
to dezinezync/Preferences
that referenced
this pull request
Dec 17, 2022
dezinezync
pushed a commit
to dezinezync/Preferences
that referenced
this pull request
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
This cannot be released until Xcode 12 final is out, but if you really need this now, you can use the Git commit in the Xcode's Swift Package Manager tab.
TODO:
NSImage.preferencesGeneralNamebecomes the correct SF Symbol before the final macOS 11 release, if so, we could revert to that. Currently, it's colored even on macOS 11.Update: It does not adopt the Big Sur look, so it cannot be used.