New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick paste #1
Comments
My first time "contributing to open source" – exciting! I think the shortcut should be The button to paste the color in the text field could be added to the far-right end of the input field and only appear on hover. I'm not sure how well this works accessibility-wise in a Mac-app. Showing the button only while hovering the respective field would make it clear which field will be pasted into, while at the same time de-cluttering the interface. And it would also have high discoverability: it's intended as a shortcut so I don't have to click the field and then paste. So I would stumble upon it when I want to click the field and the "paste"-button becomes visible inside that field. |
I agree with using Shift+Command+v. I have implemented the menu item and keyboard shortcut for this now. I don't think it makes sense to place the paste button inside the inputs, because the pasting is not tied to a specific format. The intention of the button is that you can click it to paste any of the supported formats, just like the keyboard shortcut. |
Yeah, you're right, one central button might be a smarter idea. One button above the three input fields might work. The button should be near the input fields so that connection between button and inputs is clear. And I like the idea that the button is above the input fields because then the information 'flows' from top to bottom: the button on top affects the three input fields on the bottom. |
The problem with having the button right above the inputs is that it will be a lone centered button. It's kind of a waste of vertical space and it will also not look that good. Let's try to explore some other possible solutions too. |
@m8ins What do you think of something like this? (Placing the paste button on a row above) |
Sorry for my silence, I just moved and was a bit busy unpacking the boxes. I like the placement! Not sure about the icon, though – I'd interpret it as "download" rather than "paste/import". Which icon set do you use, SF Icons? I could look through there if I find another icon that might fit. |
Yeah, I'm not happy about the paste icon. Forgot to mention that. I couldn't find a good icon for it. Help with that is most welcome. It's SF Symbols. The idea is that we can add more buttons there in the future. Maybe a contrast checker, or something else. |
Thanks. I'm going with that for now. |
I think it would be useful to be able to quickly paste a color in either Hex, HSL, or RGB. You can already do this by selecting the correct text field first, but I think it would be nice if we could support this as long as the app is active.
Open questions:
The implementation should be simple as we already have the initializers. We just try initializing the colors on after another.
Feedback wanted
The text was updated successfully, but these errors were encountered: