Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Updates to .editorconfig don't update open files #13

Closed
erikdonohoo opened this issue Jul 18, 2014 · 9 comments
Closed

Updates to .editorconfig don't update open files #13

erikdonohoo opened this issue Jul 18, 2014 · 9 comments

Comments

@erikdonohoo
Copy link

Files need to be closed and reopened for changes to the .editorconfig to be noticed.

The file should be watched and then refresh any currently open files to show the changes.

@travi
Copy link

travi commented Jul 25, 2014

+1

2 similar comments
@mstn
Copy link

mstn commented Nov 30, 2014

+1

@xlaywan
Copy link

xlaywan commented Dec 22, 2014

+1

@sindresorhus
Copy link
Owner

Yes, that would be nice, but I'm not aware of any way to do that in Atom. Though I would love to be proven wrong.

@erikdonohoo
Copy link
Author

I will have to look. But I know it is done in the atom jshint package. They watch for changes to any .jshintrc file and update the hinting.

@sindresorhus
Copy link
Owner

Sure. PR welcome.

@cemrich
Copy link

cemrich commented Oct 31, 2015

There is a fs.watch() function that could be used.
The problem is we don't know the exact files the config rules are parsed from. In most cases it will be .editorconfig on root level but there could be more config files in subdirectories as well.
Searching for this files could be expensive (however, that's just an assumption) - especially when handling deeply nested node_modules directories.

@florianb
Copy link
Collaborator

florianb commented Apr 1, 2016

We could try to watch all involved files, if one file changes the config is resembled and set.

@florianb florianb added this to the Fievel Mousekewitz milestone Apr 29, 2016
@florianb
Copy link
Collaborator

This feature will be implemented with the next (and first) feature-milestone. I will close this issue in favor of the more technical discussion in #85 - please feel free to follow up and participate!

Thank you all for contributing! 💝

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants