This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Replace 'auto' with 'unset' per the new spec #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done @alaycock! Your changes look good to me, i will have a deeper look at Tuesday and i guess i will then accept the PR, too. Thank you very much for your contribution! 🎁 |
|
I owe you a beer @alaycock - thank you very much for your support! 🍻 |
|
Glad I could help 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the maintainer's life easier, I...
npm tested my code and it's green like an 🍏,readme.md, if it was necessary andor ☕after that hard work!Resolves #193
I updated the grammar and changed all relevant instances of
autotounsetper the new terminology. If you search the repo, there are a few instances ofautoleft, but those referring to Atom's built in 'tab type' setting. It made more sense to update every instance ofautotounsetto prevent conflicting terminology throughout the repo, although it isn't necessary to do so.I also added a new test, to show that when any of the properties are
unset, the settings in the plugin will match that.