This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Use the local XO when available #41
Labels
Comments
Merged
I suspect you may have to run the linting in a child process to prevent arbitrary packages from running within the Atom security context? (Don't know much about how that all works though.) |
@novemberborn There's a dirty workaround: Lines 11 to 13 in f3d443b
|
That avoids giving the dependency access to the Atom process? |
marionebl
added a commit
to marionebl/atom-linter-xo
that referenced
this issue
Nov 13, 2016
This PR turned out way bigger than planned. Hope the noise/gain ratio is good enough. - tries to load xo, eslint an parser from cwd - introduces fallback to __dirname if resolving fails - uses proxyquire to load shareable config, plugins from cwd, too - moves linting call to forked process - removes loophole due to forked process making it obsolete - targets sindresorhus#19 - targets sindresorhus#42 - targets sindresorhus#41
marionebl
added a commit
to marionebl/atom-linter-xo
that referenced
this issue
Nov 21, 2016
* follow-up for sindresorhus#46 * builds on sindresorhus#47 * closes sindresorhus#19 * closes sindresorhus#41
marionebl
added a commit
to marionebl/atom-linter-xo
that referenced
this issue
Nov 24, 2016
* follow-up for sindresorhus#46 * builds on sindresorhus#47 * closes sindresorhus#19 * closes sindresorhus#41
marionebl
added a commit
to marionebl/atom-linter-xo
that referenced
this issue
Nov 24, 2016
* follow-up for sindresorhus#46 * builds on sindresorhus#47 * closes sindresorhus#19 * closes sindresorhus#41
sindresorhus
pushed a commit
that referenced
this issue
Nov 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Like the CLI does. Should have done this from the start. Can't remember why I didn't.
The text was updated successfully, but these errors were encountered: