Update dependencies and require Node.js 6 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| file.warn('Incorrect badge source', child2); | ||
| return; | ||
| } | ||
| if (node.depth !== 1 || child.type !== 'link' || child.url !== badgeUrl) { |
There was a problem hiding this comment.
i only made this change because xo was complaining about too much nesting depth here
| } | ||
| } | ||
| } | ||
|
|
||
| if (!hasBadge) { | ||
| file.warn('Missing Awesome badge after the main heading', node); | ||
| file.message('Missing Awesome badge after the main heading', node); |
There was a problem hiding this comment.
file.warn no longer exists
sindresorhus
changed the title
|
Awesome! Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
The bulk of this PR is updating remark-lint's usage to latest, where all rules are no longer bundled by default.
For reference, here is the list of official remark-lint plugins that are not currently being used:
There may be more, but this is just considering plugins listed in the official remark-lint monorepo.
remark-lint-no-duplicate-headings-in-sectionand several others should probably be added, but I'll leave that for a subsequent PR.All tests pass, and the CLI appears to be working as expected for me locally.
@sindresorhus I plan on adding more rules as a follow-up to this, but updating
awesome-lintto latest deps seemed to be a reasonable prerequisite.