Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add superagent #608

Closed
wants to merge 1 commit into from
Closed

Conversation

john-pettigrew
Copy link

Added a library for really easy HTTP test assertions.

@sindresorhus
Copy link
Owner

Thanks, but I'm gonna pass on this. I've used SuperTest before and it's API is just too magic. .expect() is way too overloaded and it makes it really hard to read the assertions. There are better HTTP assertion libs on npm.

@ewnd9
Copy link

ewnd9 commented Apr 30, 2017

@sindresorhus A part of your reasoning for declining #608:

I've used SuperTest before and it's API is just too magic. .expect() is way too overloaded and it makes it really hard to read the assertions

But supertest is still valuable just for wrapping an http server and sending requests.

E.g. there is the "Endpoint testing" recipe in ava docs which includes supertest but uses ava assertions.

Maybe it might still be added with a note about avoiding the built-in assertions?


Edit: whoops, I intended to post this in the newer issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants