Require Node.js 8, add known binaries, add multiple default argument sets #15
Conversation
|
@sindresorhus Bumped node version to 8, and excluded 6 from tests there. (As async doesn't work in 6, it's painful to implement this without async, and you probably would bump version yourself soon anyway.) |
sindresorhus
changed the title
index.js
Outdated
| .catch(error => { | ||
| const knownBinaryArgs = new Map([ | ||
| ['openssl', ['version']], | ||
| ['ffmpeg', ['-version']] |
There was a problem hiding this comment.
Can you include some more popular binaries with non---version version flags?
There was a problem hiding this comment.
To be honest, I can't remember any, not a type of information I try hard to remember, and everything I try of the top of my head accepts --version. But should probably put up a notice in readme incentivising people to file an issue if they find some.
I've added ffprobe and ffplay though.
There was a problem hiding this comment.
(for the notice part, it would really be best if you formulate it and put where you want, otherwise we will end up with a couple of more rounds of back and forward about one sentence)
Fixes #12.